Roll Chrome to 124 (#2610)

hardkoded · Apr 23, 2024 · 20d6fab · 20d6fab
1 parent f8ff8af
commit 20d6fab
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.upstream.json
@@ -915,13 +915,6 @@
     "expectations": ["SKIP"],
     "comment": "TODO: add a comment explaining why this expectation is required (include links to issues)"
   },
-  {
-    "testIdPattern": "[accessibility.spec] Accessibility should work",
-    "platforms": ["darwin", "linux", "win32"],
-    "parameters": ["chrome", "webDriverBiDi"],
-    "expectations": ["FAIL"],
-    "comment": "Change in A11Y tree on Canary"
-  },
   {
     "testIdPattern": "[ariaqueryhandler.spec] AriaQueryHandler queryOne (Chromium web test) should find by role \"button\"",
     "platforms": ["darwin", "linux", "win32"],

diff --git a/lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs b/lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs
@@ -87,17 +87,18 @@ await Page.SetContentAsync(@"
                             Name= "",
                             Value= "First Option",
                             HasPopup = "menu",
-                            Children= new SerializedAXNode[]{
+                            Children=
+                            [
                                 new() {
-                                    Role = "menuitem",
+                                    Role = "option",
                                     Name = "First Option",
                                     Selected= true
                                 },
                                 new() {
-                                    Role = "menuitem",
+                                    Role = "option",
                                     Name = "Second Option"
                                 }
-                            }
+                            ]
                         }
                     }
             };
@@ -188,7 +189,7 @@ await Page.SetContentAsync(@"
 
             var button = await Page.QuerySelectorAsync("button");
             Assert.AreEqual("Show", await GetAccessibleNameAsync(Page, button));
-            await button?.ClickAsync();
+            await button!.ClickAsync();
             await Page.WaitForSelectorAsync("aria/Hide");
         }
 

diff --git a/lib/PuppeteerSharp/BrowserData/Chrome.cs b/lib/PuppeteerSharp/BrowserData/Chrome.cs
@@ -13,7 +13,7 @@ public static class Chrome
         /// <summary>
         /// Default chrome build.
         /// </summary>
-        public static string DefaultBuildId => "123.0.6312.86";
+        public static string DefaultBuildId => "124.0.6367.60";
 
         internal static async Task<string> ResolveBuildIdAsync(ChromeReleaseChannel channel)
             => (await GetLastKnownGoodReleaseForChannel(channel).ConfigureAwait(false)).Version;