fix: interface_statement have decorator_list
#8
+8,980
−8,588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, the web documentation makes it appear at first glance that interface does not have decorators, but looking at the implementation, it does. It is also shown in the example code. <https://github.com/microsoft/typespec/blob/a939c140980805dc66a9b6fef70be5647b1c9680/packages/samples/specs/versioning/main.tsp#L51> The PR to fix the standard and documentation has not yet been merged, but has already been submitted. [docs: interface statement can have decorators by ncaq · Pull Request #5202 · microsoft/typespec](microsoft/typespec#5202) I found it because of a problem that the parser here could not highlight the sample code correctly. I'll submit a PR here first as well.
ncaq
force-pushed
the
interface-have-decorators
branch
from
da58a7b to
369a5f7
Compare
ncaq
changed the title
interface_statement have decorator_list
|
@happenslol |
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, the web documentation makes it appear at first glance that interface does not have decorators,
but looking at the implementation, it does.
It is also shown in the example code.
https://github.com/microsoft/typespec/blob/a939c140980805dc66a9b6fef70be5647b1c9680/packages/samples/specs/versioning/main.tsp#L51
The PR to fix the standard and documentation has not yet been merged, but has already been submitted.
docs: interface statement can have decorators by ncaq · Pull Request #5202 · microsoft/typespec
I found it because of a problem that the parser here could not highlight the sample code correctly.
I'll submit a PR here first as well.