Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added na.rm parameter for getMeth regions. #45

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

aerval
Copy link

@aerval aerval commented Oct 24, 2016

If a given region contains CpGs with with coverage 0, they are currently excluded from the averaging of the methylation values in that region. This can be highly biased if CpGs in the region have different methylation values and are compared to samples with higher coverage. Now you get NA as return if na.rm = FALSE for those regions, so you can easily exclude them from analysis. In theory I would think that this might even be the default parameter, though I understand that we should not force it here for compatibility reasons.

Notes:

  1. I am not sure whether the argument makes much sense for smoothed beta-values. I still included it from comparability
  2. I have not that much experience in R-documentation, please check whether my documentation is correct (or do you use any framework like Roxygen for that?)

@codecov-io
Copy link

Current coverage is 16.68% (diff: 0.00%)

Merging #45 into master will not change coverage

@@             master        #45   diff @@
==========================================
  Files            18         18          
  Lines          2301       2301          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            384        384          
  Misses         1917       1917          
  Partials          0          0          

Powered by Codecov. Last update 364f1fb...0e4c82a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants