Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't checkDimnames when making SummarizedExperiment #113

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

jamespeapen
Copy link

We've been getting this error when using bsseq::combine on bsseq objects with different colnames:

Error in SummarizedExperiment(assays = ans_assays,rowRanges = ans_rowRanges,: 
the rownames and colnames of the supplied assay(s) must be NULL or 
identical to those of the RangedSummarizedExperiment object (or derivative) to construct

This patch remvoves the validity check so that the SummarizedExperiment object is created without error.

@PeteHaitch
Copy link
Contributor

@jamespeapen can you please share a reprex that illustrates the problem.

@jamespeapen
Copy link
Author

https://github.com/jamespeapen/biscuiteer/blob/bsseq/bslist.rds?raw=true

bs_list <- readRDS("bslist.rds")
myBS <- bs_list[[1]]
for (i in (2:length(bs_list))) {
  myBS <- bsseq::combine(myBS, bs_list[[i]])
}

@PeteHaitch
Copy link
Contributor

Sorry, I've been very busy and haven't had time to consider this, yet.
@kasperdanielhansen what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants