Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: New Rift CS Lines #3046

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix: New Rift CS Lines #3046

merged 1 commit into from
Dec 13, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Dec 11, 2024

What

Added some new lines, probably not all though since I didnt play yet

Changelog Fixes

  • Fixed Custom Scoreboard errors from Rift update. - j10a1n15

Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 11, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 13, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will just hide the "unknown lines" information.
in this context, i dont think this is productive. instead. the user wants to see if their time is sliced or the time until the big damage is coming in.
instead of this, add a option to include those settings. I know this is more complex than simply hiding the error messages, but we dont want to "just hide" them.

remember, the default settings of the custom scoreboard should not hide information the vanilla scoreboard provides.

@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Dec 13, 2024

What?
This pr adds the new lines to the rift lines? The rift option is default enabled on the events priority list. I don't see how this hides information

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

this list keeps confusing me. we should remove the list in the future and instead iterate over all known pattern objects to build the "known pattern list" dynamically
image

@hannibal002 hannibal002 merged commit 50d877d into hannibal002:beta Dec 13, 2024
8 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 13, 2024
@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Dec 13, 2024

this list keeps confusing me. we should remove the list in the future and instead iterate over all known pattern objects to build the "known pattern list" dynamically

This is alr an Open pr #2927

@j10a1n15 j10a1n15 deleted the fix/riftr branch December 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants