Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Coop Support for Garden Plot Spray Detection #3017

Open
wants to merge 35 commits into
base: beta
Choose a base branch
from

Conversation

Chissl
Copy link
Contributor

@Chissl Chissl commented Dec 3, 2024

What

Adds detection for when another coop member sprays or clears garden plots by pulling spray status from tablist

Changelog Improvements

  • Added coop support for plot spray detection in garden. - Chissl

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Add coop support for spray timer.

Please fix these issues. For the correct format, refer to the pull request template.

@Chissl Chissl changed the title Improvement: Coop Support for Spray Timer Improvement: Coop Support for Garden Plot Spray Detection Dec 3, 2024
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 3, 2024
@Chissl Chissl marked this pull request as draft December 3, 2024 20:45
@Chissl Chissl marked this pull request as ready for review December 4, 2024 00:55
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 4, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

Copy link

github-actions bot commented Dec 4, 2024

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 4, 2024
@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 4, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/GardenAPI.kt
#	src/main/java/at/hannibal2/skyhanni/features/garden/GardenPlotAPI.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 17, 2025
Copy link

Conflicts have been resolved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants