Skip to content

Commit

Permalink
- Correct the examples' install and build scripts to acknowledge the …
Browse files Browse the repository at this point in the history
…existance of vue3

- Correct the component script type definition
  • Loading branch information
jansiegel committed Mar 10, 2023
1 parent 4ded335 commit ea450e5
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 14 deletions.
1 change: 1 addition & 0 deletions examples/next/docs/vue3/demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"author": "Handsoncode <[email protected]>",
"scripts": {
"dev": "vite",
"start": "vite",
"build": "run-p type-check build-only",
"preview": "vite preview",
"build-only": "vite build",
Expand Down
6 changes: 3 additions & 3 deletions examples/next/docs/vue3/demo/src/components/DataGrid.vue
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script>
<script lang="ts">
import { defineComponent } from 'vue';
import { HotTable, HotColumn } from '@handsontable/vue3';
import { registerAllModules } from 'handsontable/registry';
Expand Down Expand Up @@ -81,7 +81,7 @@ export default defineComponent({
:multiColumnSorting=true
:filters=true
:rowHeaders=true
:afterGetColHeader=alignHeadersProp
:afterGetColHeader=alignHeadersProp
:beforeRenderer=addClassesToRowsProp
:afterGetRowHeader=drawCheckboxInRowHeadersProp
:afterOnCellMouseDown=changeCheckboxCellProp
Expand All @@ -101,7 +101,7 @@ export default defineComponent({
/>
<HotColumn
data="rating"
className="star htCenter"
className="star htCenter"
:renderer=starsRendererProp
type="numeric"
>
Expand Down
2 changes: 1 addition & 1 deletion examples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"internal": {
"framework_dirs": [
"@(next|@(+([0-9]).+([0-9]).+([0-9])*))/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)"
"@(next|@(+([0-9]).+([0-9]).+([0-9])*))/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)"
]
}
}
20 changes: 10 additions & 10 deletions examples/scripts/clean-subpackages.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ const [version] = process.argv.slice(2);

if (version) {
console.log(`Removing:
${version}/**/(js|ts|angular|angular-*|react|vue)/node_modules
${version}/**/(js|ts|angular|angular-*|react|vue)/**/node_modules
${version}/**/(js|ts|angular|angular-*|react|vue)/**/dist
${version}/**/(js|ts|angular|angular-*|react|vue)/**/.cache
${version}/**/(js|ts|angular|angular-*|react|vue)/package-lock.json
${version}/**/(js|ts|angular|angular-*|react|vue*)/node_modules
${version}/**/(js|ts|angular|angular-*|react|vue*)/**/node_modules
${version}/**/(js|ts|angular|angular-*|react|vue*)/**/dist
${version}/**/(js|ts|angular|angular-*|react|vue*)/**/.cache
${version}/**/(js|ts|angular|angular-*|react|vue*)/package-lock.json
${version}/**/(angular|angular-*)/**/.angular`);

const removes = [];

removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)/node_modules`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)/@(!(node_modules))/node_modules`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)/@(!(node_modules))/dist`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)/@(!(node_modules))/.cache`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue)/package-lock.json`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)/node_modules`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)/@(!(node_modules))/node_modules`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)/@(!(node_modules))/dist`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)/@(!(node_modules))/.cache`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(js|ts|angular|angular-*|react|vue*)/package-lock.json`));
removes.push(rimrafPromisified(`${version}/@(!(node_modules))/+(angular|angular-*)/@(!(node_modules))/.angular`));

await Promise.all(removes);
Expand Down

0 comments on commit ea450e5

Please sign in to comment.