Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration failure caused by moments api changes #39

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Apr 25, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

将创建瞬间的接口由 /apis/api.plugin.halo.run/v1alpha1/plugins/PluginMoments/moments 更改为 /apis/console.api.moment.halo.run/v1alpha1/moments

由于此问题只会在瞬间 >= 1.5.0 版本中出现,因此将此插件版本依赖升级为 >=2.12.0

解决由于瞬间接口变更而引发的导入错误。

How to test it?

安装 >= 1.5.0 版本的瞬间

使用 1.5/1.6 版本的 Halo 备份文件进行数据导入。查看是否能够成功导入瞬间。

Which issue(s) this PR fixes:

Fixes #38

Does this PR introduce a user-facing change?

解决导入瞬间失败的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby April 25, 2024 06:58
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@JohnNiang
Copy link

Hi @LIlGG ,请先解决一下失败的 check。

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Apr 25, 2024

Hi @LIlGG ,请先解决一下失败的 check。

已解决

@JohnNiang
Copy link

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit bb9f076 into halo-sigs:main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

瞬间接口变动导致导入瞬间失败
3 participants