Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin afdian #86

Merged
merged 1 commit into from May 19, 2024
Merged

Add plugin afdian #86

merged 1 commit into from May 19, 2024

Conversation

carolcoral
Copy link
Contributor

@carolcoral carolcoral commented Apr 29, 2024

新增https://github.com/carolcoral/plugin-afdian 爱发电插件 麻烦同步到应用商店中

None

新增https://github.com/carolcoral/plugin-afdian 爱发电插件
麻烦同步到应用商店中
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby April 29, 2024 04:31
Copy link

f2c-ci-robot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ruibaby for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby changed the title 新增插件信息 Add plugin afdian Apr 29, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @carolcoral 为 Halo 生态贡献插件,以下是建议修改的内容:

  1. 包名建议改为自己的域名,而不是默认的 run.halo
  2. 如果没有用到 ui 的部分,建议删除。
  3. 插件描述文件的 license 地址不正确,https://github.com/carolcoral/plugin-afdian/blob/c6ff50481ed79b7ebc26ca346c2f7c1651272b78/src/main/resources/plugin.yaml#L23

@carolcoral
Copy link
Contributor Author

@ruibaby 已修改

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 29, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@ruibaby ruibaby merged commit 91e89cd into halo-sigs:main May 19, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants