Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update github action #84

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 8, 2023

  1. 支持构建 Console 的内容。
  2. 支持创建 Release 之后发布到 Halo 应用市场。

/kind improvement

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 8, 2023
@longjuan
Copy link
Member

longjuan commented Oct 8, 2023

更改后直接 ./gradlew build 会失败,开发时要需要手动 install
image

@ruibaby
Copy link
Member Author

ruibaby commented Oct 8, 2023

更改后直接 ./gradlew build 会失败,开发时要需要手动 install image

建议开发时手动执行 ./gradlew pnpmInstall、否则每次 build 都需要执行一遍 install。

CI 也是加了 ./gradlew pnpmInstall 的步骤的。

@guqing
Copy link
Member

guqing commented Oct 8, 2023

更改后直接 ./gradlew build 会失败,开发时要需要手动 install

符合预期,只需要 install 一次,下次 build 可以减少 不必要的 install 的时间

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2023
Copy link
Member

@longjuan longjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2023
@JohnNiang JohnNiang merged commit 84345ef into halo-dev:main Oct 8, 2023
4 checks passed
@ruibaby ruibaby deleted the chore/update-workflow branch October 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants