Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verification function to the configuration of s3 object storage policy #134

Merged
merged 9 commits into from Apr 22, 2024

Conversation

longjuan
Copy link
Member

在 S3 存储策略配置中增加了验证配置的功能。

fixes #132

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 12, 2024
@longjuan
Copy link
Member Author

目前只做了上传+删除,下载文件我认为可能会消耗外网下行流量(没填cdn地址的时候造成费用问题)。

@longjuan longjuan requested a review from guqing April 18, 2024 12:10
@longjuan
Copy link
Member Author

@halo-dev/sig-halo

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
Copy link

f2c-ci-robot bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 47b6a37 into halo-dev:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

添加配置验证功能
3 participants