Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix original file name being incorrectly replaced #129

Merged
merged 1 commit into from Apr 14, 2024

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Mar 24, 2024

修复上传目录中 ${origin-filename} 占位符被错误替换为空字符串的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen March 24, 2024 12:05
@longjuan
Copy link
Member Author

longjuan commented Apr 8, 2024

@halo-dev/sig-halo

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member

guqing commented Apr 9, 2024

/retitle Fix original file name being incorrectly replaced

@f2c-ci-robot f2c-ci-robot bot changed the title fix: retain ${origin-filename} placeholder in upload directory instead of replacing with empty string Fix original file name being incorrectly replaced Apr 9, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@guqing
Copy link
Member

guqing commented Apr 9, 2024

Hi @longjuan , 建议修改一下 release-note 的内容为此次修复造成的影响,release-note 是给用户看的,这样的描述用户可能无法理解此次修改的意义

@ruibaby ruibaby merged commit 68b1a88 into halo-dev:main Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants