Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of scrolling to the comment view after the initial loading of comments #98

Merged
merged 1 commit into from Mar 14, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 9, 2024

调整滚动到评论组件视图的时机,改为仅在分页的时候才滚动到顶部。在此之前,如果文章比较短,可以在屏幕中显示评论组件时,页面可能会自动滚动到评论组件的部分。

/kind bug

优化加载数据之后滚动到评论组件视图的时机

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 9, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang March 9, 2024 12:08
@LIlGG
Copy link
Member

LIlGG commented Mar 14, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
Copy link

f2c-ci-robot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5e0db9b into halo-dev:main Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants