Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong reply size #117

Merged
merged 1 commit into from Apr 29, 2024
Merged

fix: wrong reply size #117

merged 1 commit into from Apr 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 28, 2024

如果开启了 同时加载评论的回复,然后异步加载下一页回复时,改为使用 同时加载回复的条数 的值,如果和以前一样的 默认加载回复条数 选项作为 size 参数,那么可能出现无法正确获取下一页数据的问题。

Fixes #114

修复开启 `同时加载回复的条数` 选项时,可能无法正确加载下一页的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 28, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang April 28, 2024 03:50
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link

f2c-ci-robot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 220219d into halo-dev:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

评论回复无法显示
3 participants