Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch comments with related replies #106

Merged
merged 9 commits into from Mar 19, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 17, 2024

支持加载评论列表时同时加载对应回复。

image

TODO:

  • 在插件设置中提供设置,是否启用自动加载回复,以及默认加载条数
支持加载评论列表时同时加载对应回复。

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 17, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang March 17, 2024 08:38
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby
Copy link
Member Author

ruibaby commented Mar 17, 2024

@guqing 姐姐请帮帮我,现在需要将 ConfigMap 的属性放在注入的CommentWidget.init 里。

@ruibaby ruibaby changed the title WIP: feat: fetch comments with related replies feat: fetch comments with related replies Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 18, 2024
Signed-off-by: Ryan Wang <[email protected]>
Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is absolutely genius

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
Copy link

f2c-ci-robot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4c3da7e into halo-dev:main Mar 19, 2024
4 checks passed
@ruibaby ruibaby deleted the feat/comment-with-replies branch March 19, 2024 16:26
@ruibaby ruibaby mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants