Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong router navigation when redirect to /uc #5609

Merged
merged 2 commits into from Mar 27, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 27, 2024

What type of PR is this?

/kind bug
/area ui

What this PR does / why we need it:

修复当角色勾选禁止访问 Console 后,redirect_uri 参数无效的问题

How to test it?

测试角色禁止访问 console 时,当链接中携带 redirect_uri 参数,能否正常跳转

Which issue(s) this PR fixes:

Fixes #5417

Does this PR introduce a user-facing change?

修复当角色禁止访问 Console 后,无法正常重定向的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Mar 27, 2024
@LIlGG LIlGG added this to the 2.14.x milestone Mar 27, 2024
@ruibaby
Copy link
Member

ruibaby commented Mar 27, 2024

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.49%. Comparing base (5fdf6c0) to head (18d2e4c).
Report is 89 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5609      +/-   ##
============================================
- Coverage     56.91%   56.49%   -0.42%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19248     +280     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7812     +218     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

f2c-ci-robot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit ec4c390 into halo-dev:main Mar 27, 2024
9 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 27, 2024
@LIlGG LIlGG deleted the fix/access-console-role-router branch April 23, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新建的角色勾选 禁止访问 Console 后,redirect_uri 参数无效
3 participants