refactor: reduce the number of failures due to conflict post update

[guqing]

What type of PR is this?

/kind improvement
/area core
/milestone 2.14.x

What this PR does / why we need it:

减少文章更新因版本号冲突而失败的次数

Which issue(s) this PR fixes:

Fixes #5579

Does this PR introduce a user-facing change?

None

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (ecd8da4).
Report is 89 commits behind head on main.

Files	Patch %	Lines
...a/run/halo/app/content/AbstractContentService.java	0.00%	11 Missing ⚠️
...halo/app/core/extension/endpoint/PostEndpoint.java	0.00%	6 Missing ⚠️
...pp/core/extension/endpoint/SinglePageEndpoint.java	0.00%	6 Missing ⚠️
...ava/run/halo/app/content/impl/PostServiceImpl.java	0.00%	4 Missing ⚠️
...n/halo/app/content/impl/SinglePageServiceImpl.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5604      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.43%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19250     +282     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7814     +220     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LIlGG]

/lgtm

[JohnNiang]

Hi @guqing ,

建议不在 run.halo.app.content.impl.PostServiceImpl#updatePost 中实现 retry 逻辑。因为改方法的 post 参数已经传递过来了，重试 n 次都不会有效果。

推荐在

halo/application/src/main/java/run/halo/app/core/extension/endpoint/PostEndpoint.java

Line 200 in c2a7154

})

实现。在这里，可以重新拿到最新的文章数据，并重试整个流程。

[guqing]

Hi @guqing ,

建议不在 run.halo.app.content.impl.PostServiceImpl#updatePost 中实现 retry 逻辑。因为改方法的 post 参数已经传递过来了，重试 n 次都不会有效果。

推荐在

halo/application/src/main/java/run/halo/app/core/extension/endpoint/PostEndpoint.java

Line 200 in c2a7154

})

实现。在这里，可以重新拿到最新的文章数据，并重试整个流程。

本次修改，我并没有在 updatePost 中方法中写重试啊，你说的是哪里呢

[JohnNiang]

在 run.halo.app.content.impl.PostServiceImpl#updatePost 中 retry 的源码如下所示：

halo/application/src/main/java/run/halo/app/content/impl/PostServiceImpl.java

Lines 233 to 234 in 2011435

	.retryWhen(Retry.backoff(5, Duration.ofMillis(100))
	.filter(throwable -> throwable instanceof OptimisticLockingFailureException));

另外，这里不推荐强制修改 post 数据。

[guqing]

在 run.halo.app.content.impl.PostServiceImpl#updatePost 中 retry 的源码如下所示：

halo/application/src/main/java/run/halo/app/content/impl/PostServiceImpl.java

Lines 233 to 234 in 2011435

	.retryWhen(Retry.backoff(5, Duration.ofMillis(100))
	.filter(throwable -> throwable instanceof OptimisticLockingFailureException));

这个代码并不是在本次修改中添加的，你是建议我在此 PR 中移除它吗

[guqing]

在 run.halo.app.content.impl.PostServiceImpl#updatePost 中 retry 的源码如下所示：

halo/application/src/main/java/run/halo/app/content/impl/PostServiceImpl.java

Lines 233 to 234 in 2011435

	.retryWhen(Retry.backoff(5, Duration.ofMillis(100))
	.filter(throwable -> throwable instanceof OptimisticLockingFailureException));

另外，这里不推荐强制修改 post 数据。

有什么好的办法吗，前端传过来的参数是 Post 我无法确定要修改哪些部分，这是在后端无法知晓的总会被覆盖，并且我认为这里强制更新对文章应该没有影响，该覆盖的还是会被覆盖只要数据最终是一致的

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

[JohnNiang]

/lgtm

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JohnNiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment