New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: hide the custom annotations form by defaults #5595
refactor: hide the custom annotations form by defaults #5595
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5595 +/- ##
============================================
- Coverage 56.91% 56.48% -0.43%
- Complexity 3319 3320 +1
============================================
Files 587 595 +8
Lines 18968 19250 +282
Branches 1401 1357 -44
============================================
+ Hits 10795 10874 +79
- Misses 7594 7814 +220
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 当点击完
View More
之后,是不是得显示成View Less
呢? - 打开状态似乎是全局共享的。
打开状态看代码里确实是写的全局共享的 会记住状态 应该是设计如此 |
没打开时显示查看更多,打开时显示收起?
当前 Session。 |
IMO,每个 Modal 应当独立控制显示状态,并且每次重新打开 Modal 后默认为折叠状态。 |
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area ui
/kind improvement
/milestone 2.14.x
What this PR does / why we need it:
默认隐藏自定义元数据表单,通常这不会让用户自行修改,默认显示反而会给使用者造成心智负担。
Which issue(s) this PR fixes:
Fixes #5439
Does this PR introduce a user-facing change?