Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hide the custom annotations form by defaults #5595

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 26, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.14.x

What this PR does / why we need it:

默认隐藏自定义元数据表单,通常这不会让用户自行修改,默认显示反而会给使用者造成心智负担。

image

Which issue(s) this PR fixes:

Fixes #5439

Does this PR introduce a user-facing change?

默认隐藏文章设置等界面的自定义元数据表单。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Mar 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and wan92hen March 26, 2024 08:52
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.48%. Comparing base (5fdf6c0) to head (a71dbf6).
Report is 93 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5595      +/-   ##
============================================
- Coverage     56.91%   56.48%   -0.43%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19250     +282     
  Branches       1401     1357      -44     
============================================
+ Hits          10795    10874      +79     
- Misses         7594     7814     +220     
+ Partials        579      562      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang, LIlGG and guqing and removed request for Aanko March 26, 2024 14:27
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 当点击完 View More 之后,是不是得显示成 View Less 呢?
  2. 打开状态似乎是全局共享的。

@guqing
Copy link
Member

guqing commented Mar 27, 2024

打开状态看代码里确实是写的全局共享的 会记住状态 应该是设计如此

@ruibaby
Copy link
Member Author

ruibaby commented Mar 27, 2024

当点击完 View More 之后,是不是得显示成 View Less 呢?

没打开时显示查看更多,打开时显示收起

打开状态似乎是全局共享的。

当前 Session。

@JohnNiang
Copy link
Member

当前 Session。

IMO,每个 Modal 应当独立控制显示状态,并且每次重新打开 Modal 后默认为折叠状态。

Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Mar 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ae274db into halo-dev:main Mar 31, 2024
8 checks passed
@ruibaby ruibaby removed this from the 2.14.x milestone Mar 31, 2024
@ruibaby ruibaby added this to the 2.14.0 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望默认隐藏元数据表单的自定义数据
3 participants