Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate scroller issue in post edit page #5537

Merged
merged 1 commit into from Mar 21, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 21, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.14.x

What this PR does / why we need it:

在默认富文本编辑器下,当滚动时有概率会使页面小于正常大小。在文章最底部使用 AI 插件更加容易复现。

How to test it?

测试文章滚动时是否会小于正常大小,推荐在文章最底部使用 AI 插件来复现和测试。

Which issue(s) this PR fixes:

Fixes #3853

Does this PR introduce a user-facing change?

修复文章编辑页面出现多个滚动条导致的页面高度样式问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Mar 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove March 21, 2024 08:44
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (abae729).
Report is 72 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5537      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@ruibaby ruibaby changed the title fix: page is smaller than the normal page size fix: duplicate scroller issue in post edit page Mar 21, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4fd6353 into halo-dev:main Mar 21, 2024
8 checks passed
@LIlGG LIlGG deleted the fix/editor-exceed-page branch March 22, 2024 02:35
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

编辑文章页面出现多余的滚动条
3 participants