Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dart syntax highlighting for the code blocks in the editor #5531

Merged

Conversation

Sakura-LF
Copy link
Contributor

@Sakura-LF Sakura-LF commented Mar 20, 2024

添加代码块 dart 语言的高亮

What type of PR is this?

/kind feature
/area editor

What this PR does / why we need it:

为默认编辑器的代码块导入 dart 语言高亮

Which issue(s) this PR fixes:

Fixes #5530

Special notes for your reviewer:

Does this PR introduce a user-facing change?

编辑器的代码块支持选择 Dart 语言。

添加代码块 dart 语言的高亮
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 20, 2024
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot requested a review from guqing March 20, 2024 04:39
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Mar 20, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu March 20, 2024 04:39
@Sakura-LF Sakura-LF changed the title Update lowlight.ts 为默认编辑器代码块导入 dart 语言高亮 Mar 20, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, @Sakura-LF 感谢提交此 PR,不过这里有个问题需要解决一下。

为代码块导入 dart 语言高亮
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruibaby ruibaby changed the title 为默认编辑器代码块导入 dart 语言高亮 feat: add Dart syntax highlighting for the code blocks in the editor Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (10ec6b4).
Report is 69 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5531      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

感谢贡献!

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@JohnNiang JohnNiang requested a review from LIlGG March 20, 2024 08:00
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 70e73fa into halo-dev:main Mar 20, 2024
8 checks passed
@ruibaby ruibaby added this to the 2.14.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器里的代码块没有Dart语言高亮
5 participants