feat: comments from users with comment management permission could exempt from review #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
area/comment
guqing
reviewed
Mar 20, 2024
application/src/main/java/run/halo/app/content/comment/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5529 +/- ##
============================================
- Coverage 56.91% 56.54% -0.37%
+ Complexity 3319 3313 -6
============================================
Files 587 592 +5
Lines 18968 19203 +235
Branches 1401 1355 -46
============================================
+ Hits 10795 10858 +63
- Misses 7594 7783 +189
+ Partials 579 562 -17 ☔ View full report in Codecov by Sentry. |
|
/area core |
f2c-ci-robot
bot
added
area/core
guqing
requested changes
Mar 21, 2024
application/src/main/java/run/halo/app/content/comment/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/content/comment/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/content/comment/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/content/comment/ReplyServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/content/comment/ReplyServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/content/comment/ReplyServiceImpl.java
Outdated
Show resolved
Hide resolved
application/src/test/java/run/halo/app/content/comment/CommentServiceImplTest.java
Outdated
Show resolved
Hide resolved
|
JohnNiang
reviewed
Mar 21, 2024
application/src/main/java/run/halo/app/content/comment/CommentServiceImpl.java
Show resolved
Hide resolved
f2c-ci-robot
bot
added
the
approved
guqing
approved these changes
Mar 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area comment
/area core
/kind improvement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5468
Does this PR introduce a user-facing change?