Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormKit code input type error #5522

Merged
merged 1 commit into from Mar 18, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 18, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.14.0

What this PR does / why we need it:

修复 FormKit 中 code 输入框的类型异常,在此之前如果这样使用:

<FormKit type="code" v-model="text" />

那么 v-model 的类型会不正确。以前忽略了此问题的原因是在之前 code 类型的输入框没有以组件的形式使用过,系统中都是使用 FormKit Schema 调用的。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note-none Denotes a PR that doesn't merit a release note. labels Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.0 milestone Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 18, 2024
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link

f2c-ci-robot bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (bfaa0fb).
Report is 64 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5522      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit 21bc7fe into halo-dev:main Mar 18, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/formkit-code branch March 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants