Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show the startup status of the plugin #5520

Merged
merged 4 commits into from Apr 25, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 18, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.14.x

What this PR does / why we need it:

Show the startup status of the plugin

image

Which issue(s) this PR fixes:

Fixes #5254

Does this PR introduce a user-facing change?

插件支持显示启动中的状态。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko March 18, 2024 06:14
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang March 18, 2024 06:14
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.29%. Comparing base (5fdf6c0) to head (9158edf).
Report is 138 commits behind head on main.

❗ Current head 9158edf differs from pull request most recent head 6047b76. Consider uploading reports for the commit 6047b76 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5520      +/-   ##
============================================
- Coverage     56.91%   56.29%   -0.62%     
- Complexity     3319     3324       +5     
============================================
  Files           587      600      +13     
  Lines         18968    19665     +697     
  Branches       1401     1360      -41     
============================================
+ Hits          10795    11070     +275     
- Misses         7594     8031     +437     
+ Partials        579      564      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议提供一个呼吸 Dot 即可,不用显示文字。如果一定要显示,也建议把鼠标放上去后再显示。

@guqing
Copy link
Member

guqing commented Mar 21, 2024

建议提供一个呼吸 Dot 即可,不用显示文字。如果一定要显示,也建议把鼠标放上去后再显示。

Dot 的颜色会和后面的未绑定应用市场的 Dot 难以区分,如果不显示文字建议使用 loading 状态显示可能会好点

@JohnNiang
Copy link
Member

/ping @ruibaby

@ruibaby
Copy link
Member Author

ruibaby commented Mar 27, 2024

建议提供一个呼吸 Dot 即可,不用显示文字。如果一定要显示,也建议把鼠标放上去后再显示。

我是觉得这个 StatusDot 组件提供的 default 状态不是特别明显,所以添加了文字,因为它不属于异常,所以也不太合适用 warning 或者 error。

@ruibaby ruibaby modified the milestones: 2.14.x, 2.15.x Apr 1, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
Signed-off-by: Ryan Wang <[email protected]>
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud

@JohnNiang
Copy link
Member

我这边测试发现,看不到启动中的状态,状态一闪而过。

@ruibaby
Copy link
Member Author

ruibaby commented Apr 25, 2024

我这边测试发现,看不到启动中的状态,状态一闪而过。

目前只有在插件启动耗时长的情况下才会显示启动状态。比如创建索引。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link

f2c-ci-robot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 5a0f735 into halo-dev:main Apr 25, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.15.x, 2.15.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望插件列表可以对于 Halo 刚启动时显示插件启动中状态
3 participants