Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redefine the actuator page as the overview page #5509

Merged
merged 2 commits into from Mar 15, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 14, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.14.x

What this PR does / why we need it:

将原来的 Actuator 页面改为 Overview。

Which issue(s) this PR fixes:

Fixes #5508

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 14, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 14, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Mar 14, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen March 14, 2024 04:34
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (5fdf6c0) to head (94c571c).
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5509      +/-   ##
============================================
- Coverage     56.91%   56.58%   -0.33%     
+ Complexity     3319     3312       -7     
============================================
  Files           587      591       +4     
  Lines         18968    19170     +202     
  Branches       1401     1359      -42     
============================================
+ Hits          10795    10847      +52     
- Misses         7594     7759     +165     
+ Partials        579      564      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
ui/src/locales/es.yaml Outdated Show resolved Hide resolved
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link

f2c-ci-robot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 5cf4eae into halo-dev:main Mar 15, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 17, 2024
@ruibaby ruibaby deleted the chore/actuator-to-overview branch March 24, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将 Console 的 Actuator 的定义改为 Overview
3 participants