Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add download feature for attachment #5496

Merged
merged 2 commits into from Mar 11, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 11, 2024

What type of PR is this?

/kind feature
/area ui
/milestone 2.14.0

What this PR does / why we need it:

附件支持下载。

image

Which issue(s) this PR fixes:

Fixes #5476

Special notes for your reviewer:

测试方式:

  1. 上传若干附件。
  2. 测试下载功能是否符合预期。

Does this PR introduce a user-facing change?

为附件添加下载功能

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.0 milestone Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (5fdf6c0) to head (bf31c7e).
Report is 48 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5496      +/-   ##
============================================
- Coverage     56.91%   56.81%   -0.10%     
- Complexity     3319     3321       +2     
============================================
  Files           587      589       +2     
  Lines         18968    19082     +114     
  Branches       1401     1365      -36     
============================================
+ Hits          10795    10841      +46     
- Misses         7594     7668      +74     
+ Partials        579      573       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works very well

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link

f2c-ci-robot bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit b4729b9 into halo-dev:main Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望附件支持下载
3 participants