fix: error occurs when the link is purely numerical #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
area/editor
f2c-ci-robot
bot
added
the
needs-rebase
…-pure-digital-error
f2c-ci-robot
bot
removed
the
needs-rebase
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5479 +/- ##
============================================
- Coverage 56.91% 56.86% -0.05%
- Complexity 3319 3341 +22
============================================
Files 587 589 +2
Lines 18968 19144 +176
Branches 1401 1394 -7
============================================
+ Hits 10795 10887 +92
- Misses 7594 7674 +80
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area editor
/area ui
/milestone 2.14.x
What this PR does / why we need it:
在默认的富文本编辑器中，使用了 tiptap link ，而其中的 renderHTML 会对 href 进行处理，但当链接为纯数字的时候，
HTMLAttributes.href将不会有startsWith方法。此 PR 将在解析 renderHTML 时，将
HTMLAttributes.href转为 string，进而解决这个问题。How to test it?
测试使用默认富文本编辑器时，编写一个链接，并将其设置为纯数字。
刷新页面，查看是否具有报错。
Which issue(s) this PR fixes:
Fixes #5478
Does this PR introduce a user-facing change?