Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a title input box in the editor #5465

Merged
merged 16 commits into from Mar 18, 2024
Merged

feat: add a title input box in the editor #5465

merged 16 commits into from Mar 18, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 7, 2024

What type of PR is this?

/area editor
/area ui
/kind feature

What this PR does / why we need it:

为默认编辑器添加标题输入框。

image

Which issue(s) this PR fixes:

Fixes #5427

Special notes for your reviewer:

Does this PR introduce a user-facing change?

为默认编辑器添加标题输入框。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/editor Issues or PRs related to the Editor labels Mar 7, 2024
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. labels Mar 7, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (5fdf6c0) to head (2fae726).
Report is 63 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5465      +/-   ##
============================================
- Coverage     56.91%   56.56%   -0.35%     
+ Complexity     3319     3310       -9     
============================================
  Files           587      592       +5     
  Lines         18968    19178     +210     
  Branches       1401     1355      -46     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7769     +175     
+ Partials        579      561      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Support uc
b5aa82d 
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby
Support i18n
a137fda 
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby ruibaby requested review from guqing and LIlGG March 11, 2024 07:20
@ruibaby ruibaby changed the title WIP: feat: add a title input box in the editor feat: add a title input box in the editor Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@ruibaby ruibaby mentioned this pull request Mar 11, 2024
Merged
@ruibaby
Copy link
Member Author

ruibaby commented Mar 11, 2024

插件扩展的文档已添加在：halo-dev/docs#325

@ruibaby ruibaby added this to the 2.14.x milestone Mar 11, 2024
LIlGG
LIlGG requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无法对已经具有标题的文章、页面修改标题。

@LIlGG
Copy link
Member

LIlGG commented Mar 11, 2024

image

搜索和替换功能会被标题挤下去。实际上应该在顶部工具栏下方。

@ruibaby
Fix title updated
423a662 
Signed-off-by: Ryan Wang <[email protected]>
@ruibaby
Copy link
Member Author

ruibaby commented Mar 12, 2024

无法对已经具有标题的文章、页面修改标题。

已修复。

@LIlGG
Copy link
Member

LIlGG commented Mar 14, 2024

新建一个新文章，编写标题，保存之后会变为默认的 未命名文章。 console 与 uc 均有此问题。

@ruibaby
Copy link
Member Author

ruibaby commented Mar 14, 2024

新建一个新文章，编写标题，保存之后会变为默认的 未命名文章。 console 与 uc 均有此问题。

已修复。

JohnNiang
JohnNiang reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新建文章后输入标题，点击右上角发布按钮，标题未同步修改。

image

@ruibaby
Copy link
Member Author

ruibaby commented Mar 17, 2024

新建文章后输入标题，点击右上角发布按钮，标题未同步修改。

已修复。

JohnNiang
JohnNiang approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2024
@ruibaby ruibaby requested a review from LIlGG March 17, 2024 06:41
guqing
guqing reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LIlGG
Copy link
Member

LIlGG commented Mar 18, 2024

直接保存时会报错误。正常操作应该是显示一个 未命名文章 之类的标题。

image

@ruibaby
Fix empty title
d6e91ff 
Signed-off-by: Ryan Wang <[email protected]>
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@ruibaby
Copy link
Member Author

ruibaby commented Mar 18, 2024

直接保存时会报错误。正常操作应该是显示一个 未命名文章 之类的标题。

@LIlGG 已修复。

@ruibaby
autofocus
2fae726 
Signed-off-by: Ryan Wang <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

LIlGG
LIlGG approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 581a738 into halo-dev:main Mar 18, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/editor-title branch March 18, 2024 05:14
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 18, 2024
@ruibaby ruibaby mentioned this pull request Mar 23, 2024
Closed
f2c-ci-robot bot pushed a commit to halo-dev/docs that referenced this pull request Mar 27, 2024
@ruibaby
docs: add title prop for editor create extension point (#325)
3922a17 
为编辑器扩展添加 title 字段的描述，为 halo-dev/halo#5465 的改动添加文档。

/kind documentation

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG LIlGG approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

@LIlGG LIlGG

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

在文章编辑器上方显示文章标题
4 participants
@ruibaby @LIlGG @JohnNiang @guqing