Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the link to view notifications in the email template #5459

Merged
merged 1 commit into from Mar 7, 2024

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Mar 6, 2024

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

更新邮件模板中查看通知的链接

Which issue(s) this PR fixes:

Fixes #5458

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复邮件通知中跳转到通知中心的链接错误的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Mar 6, 2024
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (5fdf6c0) to head (fb95f59).
Report is 43 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5459      +/-   ##
============================================
- Coverage     56.91%   56.86%   -0.05%     
- Complexity     3319     3341      +22     
============================================
  Files           587      589       +2     
  Lines         18968    19144     +176     
  Branches       1401     1394       -7     
============================================
+ Hits          10795    10887      +92     
- Misses         7594     7674      +80     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruibaby
Copy link
Member

ruibaby commented Mar 7, 2024

/cherry-pick release-2.13

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link

f2c-ci-robot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit e52be2b into halo-dev:main Mar 7, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #5461

In response to this:

/cherry-pick release-2.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Mar 7, 2024
…ail template (#5461)

This is an automated cherry-pick of #5459

/assign ruibaby

```release-note
None
```
@ruibaby ruibaby added this to the 2.14.0 milestone Mar 18, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

邮件通知中尾部的“查看通知”链接为旧用户中心链接
4 participants