New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query mismatch with non-intersecting OR and nested AND condition #5452
Conversation
/cherry-pick release-2.13 |
@guqing: once the present PR merges, I will cherry-pick it on top of release-2.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5452 +/- ##
============================================
- Coverage 56.91% 56.86% -0.05%
- Complexity 3319 3341 +22
============================================
Files 587 589 +2
Lines 18968 19144 +176
Branches 1401 1394 -7
============================================
+ Hits 10795 10887 +92
- Misses 7594 7674 +80
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guqing: new pull request created: #5455 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area core
/milestone 2.14.x
What this PR does / why we need it:
修复了索引查询使用含有 OR 条件嵌套 AND 条件时若匹配数据集间无交集导致的查询结果不正确的问题
如伪查询:
or(query, and(otherQuery1, otherQuery2))
问题描述:当
query
匹配的结果与and(otherQuery1, otherQuery2)
匹配的结果无交集时 and 会将自身不匹配的数据剔除导致query
无法匹配到而出现缺少数据的问题Does this PR introduce a user-facing change?