Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: refactor default editor audio block upload logic #5421

Merged
merged 4 commits into from Mar 14, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 29, 2024

What type of PR is this?

/kind improvement
/area ui
/area editor

What this PR does / why we need it:

重构默认编辑器音频组件。使其支持上传、取消上传、从附件库选择、替换等功能。

How to test it?

直接拖动、复制或选择文件上传一个音频,查看是否显示上传进度条,取消、重试功能是否正常

Which issue(s) this PR fixes:

Fixes #5239

Does this PR introduce a user-facing change?

重构编辑器音频组件的上传逻辑,增加选择文件上传、上传进度条、取消、重试等机制。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console area/editor Issues or PRs related to the Editor labels Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (5fdf6c0) to head (c5f7909).
Report is 54 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5421      +/-   ##
============================================
- Coverage     56.91%   56.81%   -0.10%     
- Complexity     3319     3321       +2     
============================================
  Files           587      589       +2     
  Lines         18968    19082     +114     
  Branches       1401     1365      -36     
============================================
+ Hits          10795    10841      +46     
- Misses         7594     7668      +74     
+ Partials        579      573       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LIlGG LIlGG added area/ui Issues or PRs related to the Halo UI and removed area/console Issues or PRs related to the Halo Console labels Feb 29, 2024
@LIlGG LIlGG added this to the 2.14.x milestone Mar 5, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LIlGG LIlGG requested a review from ruibaby March 11, 2024 09:45
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 820c103 into halo-dev:main Mar 14, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望优化富文本编辑器音频使其支持上传文件功能
2 participants