Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: add supports for force updating of post and single page settings #907

Merged
merged 1 commit into from
Mar 15, 2023
Merged

perf: add supports for force updating of post and single page settings #907

merged 1 commit into from
Mar 15, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 15, 2023

Warning

此 PR 的改动来自：halo-dev/halo#3498
因为目前 Console 仓库已经合并到 Halo 主仓库，但主仓库的 release-2.3 分支不包含 Console，所以如果需要发布 2.3.x 的 patch 版本，依旧需要在此仓库修改。

What type of PR is this?

/kind improvement
/milestone 2.3.2

What this PR does / why we need it:

支持强制保存文章和单页面的设置，绕开后端 version 锁的机制，因为目前发现在后端 Reconcile 处理文章较慢时会影响文章的保存。

需要注意的是，这是一个不太合理的处理方式，但目前别无选择。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3339

Special notes for your reviewer:

测试方式：

  1. 同时打开多个同文章的编辑页面的窗口。
  2. 编辑任意一个窗口的文章设置。
  3. 然后再去其他窗口保存，观察是否有异常。

Does this PR introduce a user-facing change?

支持强制保存文章和页面的设置，避免因为 Version 锁的机制导致保存失败。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.2 milestone Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Mar 15, 2023
@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 3:49AM (UTC)

guqing
guqing reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
JohnNiang
JohnNiang approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit db9fcb8 into halo-dev:main Mar 15, 2023
@ruibaby ruibaby deleted the perf/force-update-post-setting branch March 15, 2023 04:14
@ruibaby
Copy link
Member Author

ruibaby commented Mar 15, 2023

/cherry-pick release-2.3

@halo-dev-bot halo-dev-bot mentioned this pull request Mar 15, 2023
Merged
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #913

In response to this:

/cherry-pick release-2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Mar 15, 2023
@halo-dev-bot
[release-2.3] perf: add supports for force updating of post and singl…
6ec3ecc 
…e page settings (#913)

This is an automated cherry-pick of #907

/assign ruibaby

```release-note
支持强制保存文章和页面的设置，避免因为 Version 锁的机制导致保存失败。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.3.2
4 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing