fixes issue #1529 - syc main and speaker view zoom #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well one thing I didn't thought about (until now) is that every browser tab with this url/presentation will be synced... If this is a problem we need to add a guid to distinguish the tabs (maybe there is such a thing already in reveal.js?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1529 - syc main and speaker view zoom
It uses a BroadcastChannel to communicate between the windows. The sync is in both ways.
The new config option
syncZoomcan be used to disable the sync.I also noticed that
zoomLevelis used anywhere outside this plugin...I could not find anything about semicolons in
CONTRIBUTING.md, so I just tried to stick with the general style and add them (I normally leave them out)