Fix incorrect line numbers in error messages #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximebuyse
force-pushed
the
fix-879
branch
from
f826fd7
to
8ad8363
Compare
jschneider-bensch
approved these changes
Sep 11, 2024
franziskuskiefer
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879
The crate
annotate-snippetsthat we use for reporting error messages has a parameterline_startthat corresponds to the line number of the first line that we pass (the source code is passed as a string in another parameter). In our case we always give the full source code soline_startshould be 1 (and not the line number at which the error is located).