Fix step boundaries in fold_range_step_by #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run into case where index boundaries need to be precise for
fold_range_step_by
, let's consider the following caseThe steps are the following
[0, 4, 8, 12, 16, 20, 24, 28]
so the boundary for index isi <= 28
but by default I geti < 32
by the conditionv i < v end_
infold_range_step_by
, I adjusted that with proper condition in this PR.