Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recursing twice on the arguments. #877

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Avoid recursing twice on the arguments. #877

merged 1 commit into from
Sep 4, 2024

Conversation

maximebuyse
Copy link
Contributor

Fixes #875

The recursive call on the arguments was done twice in some cases which leads to an exponential complexity. The fix is just to avoid the double recursive call.

franziskuskiefer
franziskuskiefer approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The produced F* doesn't look very nice. But that's a separate issue.

@franziskuskiefer franziskuskiefer added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 46ea40a Sep 4, 2024
13 checks passed
@franziskuskiefer franziskuskiefer deleted the fix-exponential-visiting-in-specialize branch September 4, 2024 14:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow for deep expressions in bincode serialization/deserialization
2 participants
@maximebuyse @franziskuskiefer