Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsize for certain types #856

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Aug 19, 2024

Subsumes #854: this PR removes entirely unsize calls whenever it is called on arrays, in the F* backend.

The advantages are:

  • no unsize calls at all
  • easy to support other kinds of unsize which might not be identity, just by adding F* instances (or go the full way and hardcode something in the engine)

@W95Psp W95Psp added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 096f0eb Aug 19, 2024
13 checks passed
@W95Psp W95Psp deleted the remove-unsize-for-certain-types branch August 19, 2024 11:00
W95Psp added a commit to cryspen/libcrux that referenced this pull request Aug 20, 2024
karthikbhargavan pushed a commit to cryspen/libcrux that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants