refactor(engine): complete cleanup of ast_utils
#442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AST utils used to be one monolithic file without good organization and with no documentation at all. This commit drops `ast_utils.ml` in favor of `ast_utils/*` modules, and reoganize things. I intend on documenting everything in `ast_utils/*`.
W95Psp
force-pushed
the
cleanup-ast-utils
branch
from
36c2461
to
388c250
Compare
franziskuskiefer
added
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AST utils used to be one monolithic file without good organization and with no documentation at all.
This commit drops
ast_utils.mlin favor ofast_utils/*modules, and reoganize things.I intend on documenting everything in
ast_utils/*.STATUS:
Before #504, this PR was adding even more functor instantiation all over the place, creating again a lot more visitors, making things even slower and more painful.
But now, I should be able to rebase that PR!