Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine: refactor the module ast_utils #599

Open
W95Psp opened this issue Apr 11, 2024 · 4 comments
Open

Engine: refactor the module ast_utils #599

W95Psp opened this issue Apr 11, 2024 · 4 comments
Labels
engine Issue in the engine enhancement New feature or request

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Apr 11, 2024 •
edited
Loading

ast_utils.ml is a big module providing a ton of different, unrelated utils on the AST.
That'd be better to split it into smaller units.
@W95Psp
Copy link
Collaborator Author

W95Psp commented Apr 11, 2024

#442

@W95Psp W95Psp linked a pull request Apr 11, 2024 that will close this issue
refactor(engine): complete cleanup of ast_utils #442
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 1, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Sep 16, 2024

Very much relevant, I'd like to address that soon.

@W95Psp W95Psp reopened this Sep 16, 2024
@W95Psp W95Psp added enhancement New feature or request engine Issue in the engine and removed stale labels Sep 16, 2024
@W95Psp W95Psp changed the title Cleanup of ast_utils Engine: cleanup of ast_utils Oct 2, 2024
@W95Psp W95Psp changed the title Engine: cleanup of ast_utils Engine: refactor the module ast_utils Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine Issue in the engine enhancement New feature or request
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(engine): complete cleanup of ast_utils hacspec/hax
1 participant
@W95Psp