Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if folder is empty #22

Merged
merged 6 commits into from
Aug 18, 2020
Merged

Conversation

vltansky
Copy link
Member

@vltansky vltansky commented Jun 11, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Check if folder is empty

√ D:\projects\create-html5-boilerplate\out\null is not empty folder, proceed? ... yes
√ Select language » English (en)
√ html5-boilerplate@latest copied to D:\projects\create-html5-boilerplate\out\null in 3.09 seconds . Have fun!
√ D:\projects\create-html5-boilerplate\out\null is not empty folder, proceed? ... no
Aborted

This branch is based on lang branch as it has a lot of changes including prompts module.

@vltansky vltansky changed the title Check folder feat: check if folder is empty Jun 11, 2020
@roblarsen
Copy link
Member

Nice. We'll work on getting this in once the lang branch is merged.

@roblarsen roblarsen added this to the 0.2.0 milestone Jun 12, 2020
@vltansky
Copy link
Member Author

@roblarsen @coliff Should -y (skip argument) skip this question?

@vltansky vltansky marked this pull request as ready for review June 18, 2020 16:55
@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2020

This pull request introduces 1 alert when merging 63b404c into e3dfaba - view on LGTM.com

new alerts:

  • 1 for Missing await

@vltansky
Copy link
Member Author

vltansky commented Jun 25, 2020

This one is ready too. Although I still have a problem with testing.. I'd be happy for a help. Need to mock prompt node module somehow..

@roblarsen
Copy link
Member

@vltansky do you want to open an issue that describes the question you have about testing? We can focus on fixing that and do "help wanted" if we need to. I'll work on merging this in.

@vltansky
Copy link
Member Author

vltansky commented Aug 18, 2020

@roblarsen
Opened issue: #50

Do you want to merge this? And leave tests subject for separate future PR (as it not directly blocking this PR, but overall issue)?

@roblarsen
Copy link
Member

👍

@roblarsen roblarsen merged commit bb1c0f8 into h5bp:master Aug 18, 2020
@vltansky vltansky mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants