Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display Active Table filter count #1689 #2220

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Ultare1717
Copy link

@Ultare1717 Ultare1717 commented Dec 8, 2023

closes #1689

image

This is the solution that we have defined and a video demonstrating that the filters work:

wave.filter.count.in.examples.table.mov

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

@Ultare1717 Ultare1717 changed the title Feat/issue 1689 feat: fix Active Table filter count #1689 Dec 13, 2023
@Ultare1717 Ultare1717 changed the title feat: fix Active Table filter count #1689 feat: Add Active Table filter count #1689 Dec 13, 2023
@Ultare1717 Ultare1717 changed the title feat: Add Active Table filter count #1689 feat: Display Active Table filter count #1689 Dec 13, 2023
@Ultare1717 Ultare1717 marked this pull request as ready for review December 13, 2023 10:10
@Ultare1717 Ultare1717 marked this pull request as draft December 13, 2023 10:14
@Ultare1717 Ultare1717 marked this pull request as ready for review December 14, 2023 04:50
@mturoci
Copy link
Collaborator

mturoci commented Dec 14, 2023

#1689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display active table filter count
3 participants