[POC] QUIC on Streams #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… zero-byte input
…d in QoS mode, available space could be smaller than max_frame_size. But because the frame is being written up to the end of the buffer, Length field is omitted. Emitting Length field alaways is a tentative fix.
…ard-coded to 16384
…gth field. In addition, as of this commit, FIN-only frame will always carries the length field, even if the protocol is QUIC v1. We anticipate the downside of the change to be negligible as such a frame can be used only at the tail of the packet payload.
…ng ptrdiff_t to unsigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces three new functions:
quicly_qos_new,quicly_qos_send, andquicly_qos_receive, and adds one callback:quicly_qos_is_writing.When utilizing QUIC on Streams instead of QUIC version 1, applications should use the aforementioned send and receive functions instead of
quicly_sendandquicly_receive. Quicly will continue to guide applications on when to invoke the send function; applications can determine the appropriate timing by callingquicly_get_first_timeout.quicly_get_first_timeoutwill call thequicly_qos_is_writingto see if quicly can write more.