Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client app: added common udp_wait_readready function #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxsharabayko
Copy link
Contributor

There is a duplicated code in the client application, which implements waiting for read-readiness on a UDP socket.
This code is combined into a single function to reduce code duplication and cognitive complexity.

udp_wait_readready(int fd, quicly_conn_t** connections, size_t num_connections, int64_t client_enqueue_rq_at)

timeout_at = client_enqueue_rq_at;

if (timeout_at != INT64_MAX) {
int64_t delta = timeout_at - ctx.now->cb(ctx.now);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here in case of client the connection context was used instead of the global ctx. Does it make any difference?

quicly_context_t *ctx = quicly_get_context(conn);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant