Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #474 by removing @Inject annotation #475

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

keinhaar
Copy link
Contributor

I've removed the dependency to javax.inject completely.
The only method that used the annotation @Inject was the
doSomething() method in WebAppProjectCreator, but that method seems to do nothing because it just gets some configuration elements without using them.
So i've removed the complete method.
After building the plugin installs in eclipse-2023-12 and seems to work normally.

@niloc132
Copy link
Member

If a reviewer can validate that this all works as expected, I'll get it merged and released to the plugin site.

Copy link
Contributor

@protoism protoism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with eclipse 2023-12 (Windows) on a clean installation.
No problem with installation and web app creation
The patch looks reasonable, and... yes, it looks like the removed code was good for nothing

@protoism protoism merged commit 99612c0 into gwt-plugins:main Feb 12, 2024
1 check passed
@protoism
Copy link
Contributor

Merged.

@blacatena
Copy link

blacatena commented Apr 22, 2024

Can you get this released to the plugin site? Getting it through there still fails.

If not... I'll have to figure out how to build this myself (I have zero experience in Eclipse plugins).

We've reached a point where we are upgrading Java away from 8 (finally!) and we're dead in the water with that until we resolve this (i.e., get the latest Eclipse, running Jetty 12).

@niloc132
Copy link
Member

niloc132 commented Apr 23, 2024

@blacatena I appreciate your frustration, but there is no need to build yourself, there is a download available from our CI builds - pick the latest at https://github.com/gwt-plugins/gwt-eclipse-plugin/actions?query=branch%3Amain, click repository under the Artifacts heading, and install that locally.

Building it yourself should just be a matter of checking out the code and running mvn package, which will result in a local copy of the repository that you can install to eclipse. Please see https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/main/README.md#build for more information.

This project is run by volunteers - my own work is largely limited to helping with the "devops" side of thing and a bit of code review. Before we cut the next release we intend to fix #478, then we will roll it out. If you're interested in assisting with development or sponsoring someone to do so, please reach out in that issue or off list.

@blacatena
Copy link

@niloc132 No implication of frustration was intended! In the end it's just "the job". And I appreciate all the work you guys are doing. If I weren't a year away from retiring, I'd sign on to help (who knows, maybe I'll want to when I do retire). I talked to my co-worker about maybe getting involved.

It took some sorting out but we were able to grab the built repository.zip and install it, and all is well now. Well, at least well on that front... sorting out how to convert 20 years of Java 8 development into Java 17+ is another thing. My goal is to make everything all shiny and new... and retire without worrying about my phone ringing.

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants