Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing default GWF api from GWPY_FRAME_LIBRARY environment variable #1726

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

duncanmmacleod
Copy link
Member

This PR adds support for parsing the preferred (default) GWF API from the GWPY_FRAME_LIBRARY environment variables, allowing users to override the default search order.

Closes #1720.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffffb86) 94.6% compared to head (7c4ba05) 94.3%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1726     +/-   ##
=======================================
- Coverage   94.6%   94.3%   -0.3%     
=======================================
  Files        241     242      +1     
  Lines      18620   18642     +22     
=======================================
- Hits       17619   17598     -21     
- Misses      1001    1044     +43     
Flag Coverage Δ
Conda 94.3% <100.0%> (+<0.1%) ⬆️
Linux 94.2% <100.0%> (-0.4%) ⬇️
Windows 85.0% <100.0%> (+<0.1%) ⬆️
macOS 93.9% <100.0%> (+<0.1%) ⬆️
python3.10 94.3% <100.0%> (+0.2%) ⬆️
python3.11 94.3% <100.0%> (+0.1%) ⬆️
python3.12 ?
python3.8 94.3% <100.0%> (-0.3%) ⬇️
python3.9 94.3% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanmmacleod duncanmmacleod added this to the GWpy 3.1.0 milestone Dec 7, 2023
@duncanmmacleod duncanmmacleod added gwpy.timeseries Issues/changes related to the gwpy.timeseries module issue:feature-request Issue requests a new feature labels Dec 7, 2023
@duncanmmacleod duncanmmacleod self-assigned this Dec 7, 2023
@duncanmmacleod duncanmmacleod added api:minor Proposed changes introduce minor (backwards-compatible) changes to the API and removed issue:feature-request Issue requests a new feature labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:minor Proposed changes introduce minor (backwards-compatible) changes to the API gwpy.timeseries Issues/changes related to the gwpy.timeseries module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying default GWF library via environment variable
1 participant