Panic on missing join clause

Fix #43
gwenn · Mar 16, 2024 · 0170578 · 0170578
1 parent 37171cd
commit 0170578
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/lexer/sql/test.rs b/src/lexer/sql/test.rs
@@ -287,6 +287,14 @@ fn natural_join_on() {
     );
 }
 
+#[test]
+fn missing_join_clause() {
+    expect_parser_err_msg(
+        b"SELECT a FROM tt ON b",
+        "a JOIN clause is required before ON",
+    );
+}
+
 #[test]
 fn unknown_table_option() {
     expect_parser_err_msg(b"CREATE TABLE t(x)o", "unknown table option: o");

diff --git a/src/parser/ast/mod.rs b/src/parser/ast/mod.rs
@@ -799,7 +799,9 @@ impl FromClause {
                 self.joins = Some(vec![jst]);
             }
         } else {
-            debug_assert!(jc.is_none());
+            if jc.is_some() {
+                return Err(custom_err!("a JOIN clause is required before ON"));
+            }
             debug_assert!(self.select.is_none());
             debug_assert!(self.joins.is_none());
             self.select = Some(Box::new(table));