Skip to content

Commit

Permalink
Manager: Fix performance issue when searching for commander tags
Browse files Browse the repository at this point in the history
By not saving the found events, this ended up going through all the events for each player.
  • Loading branch information
Sejsel committed Aug 18, 2023
1 parent 5087e08 commit 702b4ea
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions ArcdpsLogManager/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
This is the full changelog of the arcdps Log Manager.

## Log Manager v1.10

#### New features
- Added a button to set the dps.report user token in the settings
- Added max parallel threads setting to the Game data gathering tab (View -> Debug Data must be enabled to see this tab).

#### Performance improvements
- Improved log processing performance by ~25% for 10man logs, even more in WvW logs.

#### Fixes
- Fixed log detail pane not appearing for selected logs processed with Log Manager versions 1.3 and older.
- Fixed a stray debug data section appearing when multiple logs were selected even if debug data wasn't enabled
Expand Down
2 changes: 1 addition & 1 deletion ArcdpsLogManager/Logs/LogData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public void ProcessLog(LogAnalytics logAnalytics)
HealthPercentage = 0;
}

var tagEvents = log.Events.OfType<AgentTagEvent>().Where(x => x.Marker.Id != 0 && x.Agent is Player);
var tagEvents = log.Events.OfType<AgentTagEvent>().Where(x => x.Marker.Id != 0 && x.Agent is Player).ToList();
Players = analyzer.GetPlayers().Where(x => x.Identified).Select(p =>
new LogPlayer(p.Name, p.AccountName, p.Subgroup, p.Profession, p.EliteSpecialization,
GetGuildGuid(p.GuildGuid))
Expand Down

0 comments on commit 702b4ea

Please sign in to comment.