Skip to content

Commit

Permalink
Analytics: Fix missing combat item filter logic for glider events
Browse files Browse the repository at this point in the history
  • Loading branch information
Sejsel committed Jun 28, 2024
1 parent 31a107c commit 3ece805
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions EVTCAnalytics/Parsing/CombatItemFilters.cs
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ private static IEnumerable<StateChange> GetDirectStateChangesForEventType(Type e
if (eventType == typeof(EffectEvent)) return new[] { StateChange.Effect };
if (eventType == typeof(EffectStartEvent)) return new[] { StateChange.Effect2 };
if (eventType == typeof(EffectEndEvent)) return new[] { StateChange.Effect2 };
if (eventType == typeof(AgentGliderOpenEvent)) return new[] { StateChange.Glider };
if (eventType == typeof(AgentGliderCloseEvent)) return new[] { StateChange.Glider };

if (eventType == typeof(BuffEvent)) return Array.Empty<StateChange>();
if (eventType == typeof(BuffRemoveEvent)) return Array.Empty<StateChange>();
Expand Down Expand Up @@ -307,6 +309,8 @@ private static bool IsDirectBuffDamage(Type eventType)
if (eventType == typeof(EffectEvent)) return false;
if (eventType == typeof(EffectStartEvent)) return false;
if (eventType == typeof(EffectEndEvent)) return false;
if (eventType == typeof(AgentGliderOpenEvent)) return false;
if (eventType == typeof(AgentGliderCloseEvent)) return false;

if (eventType == typeof(BuffEvent)) return false;
if (eventType == typeof(BuffRemoveEvent)) return false;
Expand Down Expand Up @@ -375,6 +379,8 @@ private static bool IsDirectSkillCast(Type eventType)
if (eventType == typeof(EffectEvent)) return false;
if (eventType == typeof(EffectStartEvent)) return false;
if (eventType == typeof(EffectEndEvent)) return false;
if (eventType == typeof(AgentGliderOpenEvent)) return false;
if (eventType == typeof(AgentGliderCloseEvent)) return false;

if (eventType == typeof(BuffEvent)) return false;
if (eventType == typeof(BuffRemoveEvent)) return false;
Expand Down Expand Up @@ -443,6 +449,8 @@ private static IEnumerable<Result> GetDirectPhysicalResultsForEventType(Type eve
if (eventType == typeof(EffectEvent)) return Array.Empty<Result>();
if (eventType == typeof(EffectStartEvent)) return Array.Empty<Result>();
if (eventType == typeof(EffectEndEvent)) return Array.Empty<Result>();
if (eventType == typeof(AgentGliderOpenEvent)) return Array.Empty<Result>();
if (eventType == typeof(AgentGliderCloseEvent)) return Array.Empty<Result>();

if (eventType == typeof(BuffEvent)) return Array.Empty<Result>();
if (eventType == typeof(BuffRemoveEvent)) return Array.Empty<Result>();
Expand Down

0 comments on commit 3ece805

Please sign in to comment.