Add --version #182
Open
Add --version #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyzmo
requested changes
Nov 21, 2017
| def cli(): # pragma: no cover | ||
| try: | ||
| sys.exit(main(docopt(__doc__.format(self=sys.argv[0].split(os.path.sep)[-1], version=__version__)))) | ||
| sys.exit(main(docopt(__doc__.format(self=sys.argv[0].split(os.path.sep)[-1], version=__version__), |
There was a problem hiding this comment.
the --help version should also contain --version
| @@ -586,9 +588,39 @@ def main(args): | |||
| return 2 | |||
|
|
|||
|
|
|||
| class Version: | |||
There was a problem hiding this comment.
This should be moved to either:
- the tools module if left as is ;
- the kwargparse module if integrated to the kwargparse/dispatcher system
- its own new module otherwise (i.e.: as a new independant module)
| @@ -26,6 +27,9 @@ | |||
| import os, json, platform | |||
|
|
|||
|
|
|||
| SERVICE_PACKAGE = pybitbucket | |||
There was a problem hiding this comment.
I don't really like that pattern, it feels a bit redundant with the register target decorator. What I'd rather do is either make a new decorator that manages version, or add an argument to register_target with the version string.
There was a problem hiding this comment.
the other better side of that is that you don't need the full loading of the module into the main system, and if a module has a version string that's not standard (i.e. not using __version__ we're good for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.