Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C implementation. More efficient stalinSort. Dynamic memory removal. #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laskonka18
Copy link

Dynamic memory removal, because of hidden computational complexity.

…because of hidden computational complexity.
@gustavo-depaula
Copy link
Owner

gustavo-depaula commented Aug 3, 2019

hey mate, thanks for your input. it seems something similar was done in #70
do you want to suggest an improvement/review it?

@kodejuice
Copy link

closed my pull request, this is much better,

the author should do this

great work! it seems that it would fit better in a separate file, could you do that? something called stalin-sort-in-place.c (feel free to decide a better name)

@gustavo-depaula
Copy link
Owner

great attitude @kodejuice!

@pascaldekloe
Copy link
Contributor

Did the same in #71, with the addition of zeroing out the remaining elements.

@gustavo-depaula
Copy link
Owner

@laskonka18 sorry for the delay, can you fix the conflixt so we can merge this?

@Artoria2e5
Copy link
Contributor

https://github.com/gustavo-depaula/stalin-sort/blob/master/C/stalin-sort.c no longer has the realloc thanks to @graudtv. Not even the (old).c has it by this point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants