Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Python #200

wants to merge 3 commits into from

Conversation

rerik
Copy link

@rerik rerik commented Oct 29, 2023

I made clean pythonic implementation. I hope, you like it

gustavo-depaula
gustavo-depaula reviewed Dec 20, 2023
View reviewed changes
Copy link
Owner

@gustavo-depaula gustavo-depaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! It's pretty great! But we favor having multiple implementations instead of overriding the existing ones. Can you move your code to new files or even a new folder inside python and keep the old one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-depaula gustavo-depaula gustavo-depaula left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rerik @gustavo-depaula